Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

116 RC Threshold Calibration #131

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

116 RC Threshold Calibration #131

wants to merge 3 commits into from

Conversation

zhaoshengEE
Copy link
Collaborator

No description provided.

Copy link
Owner

@hannahvsawiuk hannahvsawiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about using FileSystem. I am pretty sure this creates a file within the Arduino's on board memory. Try this: https://electronics.stackexchange.com/questions/54/saving-arduino-sensor-data-to-a-text-file

@hannahvsawiuk hannahvsawiuk linked an issue Mar 23, 2020 that may be closed by this pull request
@@ -0,0 +1,100 @@
#include<EEPROM.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls format using Ctrl + Shift + I on vscode

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes yes


//**********Right Joystick**********//
//MAX Position
Serial.println("Please move the right joystick to the maximum position\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you specificy that the maximum position is up (like forwards)

rc2 = pulseIn(rc_channel2, HIGH);
EEPROM.put(rc2_addr_max, rc2);
//MIN Position
Serial.println("Please move the right joystick to the minimum position\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify what the minimum position is


//**********Switch A(Remote E-stop)**********//
//Position 0
Serial.println("Please move Switch A to 0\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to label these on the RC itself somehow

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

int switchB = 7; //Channel 6

//Address in EEPROM
const int rc2_addr_max = 0;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider moving this pinout.h and use #define instead

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this file pinout agnostic

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g.

#@file pinout.h
#define RC_CHANNEL2    3
#define RC_CHANNEL3    4

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further, the EEPROM addresses need to be in a header file (e.g. eeprom_io.h). This will need to be used by the main firware to read from these addresses. Don't define them as const ints in the scope of this program.

Copy link
Owner

@hannahvsawiuk hannahvsawiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments I left.

//**********Right Joystick**********//
//MAX Position
Serial.println("Please move the right joystick to the maximum position\n");
delay(2000);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use delays. I suggest doing something like the following:

  1. Indicate which measurement.
  2. Wait for a start character.
  3. Record the values for 5 seconds or until the stop character is sent. This gives the user a small window to move the joystic. Note: I would suggest checking the data rate so a bunch of data is stored and possible lost. Maybe 2 seconds is good. Throughout this period, keep sampling.
  4. Find the max/min from the collected data and save the value to the EEPROM

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest creating a seperate function for this with a few arguments:

int get_threshold(const char * user_question, bool min = false, bool max = false, bool mean = false, uint8_t rc_pin, uint8_t eeprom_addr)
{
/*
 1.print the string
 2.wait for a start char
 3.sample and store into a temp array
 4.wait for time end or end char. Or, cancel char which exits the measurement and re-runs the question routine.
 5.get min/max/mean
 6.write value to eeprom
 7.return true is successful data collection and eeprom write, else false
*/
}

int switchB = 7; //Channel 6

//Address in EEPROM
const int rc2_addr_max = 0;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further, the EEPROM addresses need to be in a header file (e.g. eeprom_io.h). This will need to be used by the main firware to read from these addresses. Don't define them as const ints in the scope of this program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RC Threshold Calibration Routine
3 participants