Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support dates in Hugo 0.76 (but not earlier) #361

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

henryiii
Copy link
Collaborator

The upgrade to 0.76 broke the dates in this theme. This is a possible fix, as suggested in gohugoio/hugo#7822
though it might only work on 0.76+. Since locally and on CI I'm always up to date with Hugo, this was good enough for me, though maybe there's a compatible way to do this? (also, maybe someone should verify that 0.75 does break with this - since a date was never a "count", this seems to make more sense).

@hubertbanas
Copy link

Can we please have this merged?

@henryiii
Copy link
Collaborator Author

Not up to me. :(

@joaojunior
Copy link

@henryiii Thanks for it. I have exactly this problem and your PR resolve it. I'm using the Hugo in version v0.76.5/extended

@joaojunior
Copy link

@halogenica Do you have any plans to accept this? I know that keep an open-source project is not easy. Do you need some help?

@halogenica halogenica merged commit b4736e7 into halogenica:master Jan 6, 2021
@halogenica
Copy link
Owner

Thank you very much @henryiii for your consistent high quality fixes, and to everyone for your thumbs up to prioritize this fix. I had hoped to do a sweep of top bugs over the holidays but didn’t get around to it. I’ll look through other top rated issues and merge them. Sorry again for the radio silence!

@joaojunior
Copy link

@halogenica Thank you so much!!!

@iaeiou
Copy link

iaeiou commented Jan 8, 2021

maybe someone should verify that 0.75 does break with this

Unfortunately it does break on 0.75.1: instead of Posted on June 28, 2020 we get Posted on map[Count:June 28, 2020]

@henryiii
Copy link
Collaborator Author

henryiii commented Jan 8, 2021

@iaeiou Is it possible to update? At this point, 0.76 has been out for some time, and it's usually easy in go to get the latest version (go's all in one binaries shine here). Could we just depend on 0.76+?

@henryiii henryiii deleted the fix/0.76 branch January 8, 2021 16:22
@henryiii henryiii restored the fix/0.76 branch January 8, 2021 16:22
@henryiii
Copy link
Collaborator Author

henryiii commented Jan 8, 2021

(Just in case someone depends on it, I'll leave my branch open for a bit, but expect it to close in the near future if I clean things up)

@iaeiou
Copy link

iaeiou commented Jan 8, 2021

@iaeiou Is it possible to update?

I'm using the hosting services of the french non-profit Framasoft, I'll ping the dev team

I'll keep you updated

@iaeiou
Copy link

iaeiou commented Jan 10, 2021

I'll ping the dev team

Done, in french, here

@RoneoOrg
Copy link
Collaborator

A workaround was found (see here, in french) and Hugo is now updated - problem fixed!

dustymabe added a commit to dustymabe/dustymabe.com that referenced this pull request Mar 28, 2021
major0 pushed a commit to major0/beautifulhugo that referenced this pull request Mar 2, 2022
fix: support dates in Hugo 0.76 (but not earlier)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants