Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve baseUrl in redirect URI with external URL #74

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

JohnNiang
Copy link
Contributor

This PR resolves baseUrl in redirect URI {baseUrl}/{action}/oauth2/code/{registrationId} with external URL instead of current request. This will resolve the problems caused by reverse proxy server or CDN.

/kind improvement

Fixes #73

解决回调地址配置正确但实际跳转时出错的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Oct 30, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby October 30, 2024 03:38
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
Copy link

f2c-ci-robot bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 8cc859d into halo-sigs:main Oct 30, 2024
2 checks passed
@JohnNiang JohnNiang deleted the refactor/resolve-base-url branch November 1, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to resolve baseUrl with external URL instead of from current request
2 participants