Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supports redirecting to a specified page after successful login #33

Merged
merged 4 commits into from
Jul 3, 2023
Merged

feat: supports redirecting to a specified page after successful login #33

merged 4 commits into from
Jul 3, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 2, 2023 •
edited
Loading

What this PR does?

登录成功后支持跳转到指定页面

/kind feature

Fixes #32

登录成功后支持跳转到指定页面

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 2, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby June 2, 2023 07:46
@guqing guqing force-pushed the feature/32 branch 2 times, most recently from e9fd316 to 1a4b4a1 Compare June 2, 2023 10:16
@ruibaby ruibaby mentioned this pull request Jun 12, 2023
Merged
ruibaby
ruibaby reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@guqing guqing requested a review from JohnNiang June 13, 2023 03:07
f2c-ci-robot bot pushed a commit to halo-dev/halo that referenced this pull request Jun 26, 2023
@ruibaby
feat: add redirect support for social auth provider (#4063)
e13beb4 
#### What type of PR is this?

/area console
/kind feature
/milestone 2.7.x

#### What this PR does / why we need it:

三方登录时支持传入 `login_redirect_uri` 参数，以让三方登录提供方支持适配登录后重定向到具体页面的功能。

#### Which issue(s) this PR fixes:

Fixes #4029

#### Special notes for your reviewer:

测试方式：

1. 可以使用 halo-sigs/plugin-oauth2#33 进行测试。
2. 手动在登录页面构造如 https://127.0.0.1:8090/console/login?redirect_uri=/ 的地址，观察使用三方登录之后是否会跳转到指定页面。

#### Does this PR introduce a user-facing change?

```release-note
Console 端三方登录支持重定向参数。
```
ruibaby
ruibaby reviewed Jul 3, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@guqing
Copy link
Member Author

guqing commented Jul 3, 2023

/cc @halo-sigs/halo

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 3, 2023

@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-sigs/halo.

Note that only halo-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @halo-sigs/halo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@guqing guqing requested a review from JohnNiang July 3, 2023 06:42
@guqing guqing requested a review from JohnNiang July 3, 2023 07:24
JohnNiang
JohnNiang approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 3a4bf91 into main Jul 3, 2023
@guqing guqing deleted the feature/32 branch July 3, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@JohnNiang JohnNiang

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

认证成功后支持跳转到指定URI
3 participants
@guqing @JohnNiang @ruibaby