Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct dysfunctional test cases #152

Open
wants to merge 2 commits into
base: development-collecting-new-test-cases
Choose a base branch
from

Conversation

rmassei
Copy link

@rmassei rmassei commented Nov 22, 2024

This PR contains:

  • a new test-case for the benchmark
    • I hereby confirm that NO LLM-based technology (such as github copilot) was used while writing this benchmark
  • new dependencies in requirements.txt
    • The environment.yml file was updated using the command conda env export > environment.yml
  • new generator-functions allowing to sample from other LLMs
  • new samples (sample_....jsonl files)
  • new benchmarking results (..._results.jsonl files)
  • documentation update
  • bug fixes

Related github issue (if relevant):
closes #144
closes #145
closes #146

Short description:

  • Bug fixes of the case-studies:
    • image_metadata_reading.ipynb
      Action take: I rephrase the docstring and the assert-statement in a more clear way
    • read_ome_xml_from_ome_tiff.ipynb
      Action take: Problem solved by including the xml encoding
    • tiff_metadata_reading.ipynb
      Action take: Working for me on Windows with bioio 1.1.0 and bioiotifffile 1.0.0

How do you think will this influence the benchmark results?

Why do you think it makes sense to merge this PR?

  • It is nice to have some bug-fixes case-studies

@haesleinhuepf
Copy link
Owner

Hi @rmassei ,

thanks for sending this PR so timely! Just a quick question: There is a "oryx-build-commands.txt" in the submission. What is it necessary for?

Thanks again!

Best,
Robert

@rmassei
Copy link
Author

rmassei commented Nov 22, 2024

Ah, I did not noticed, probably a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants