fix: undefined components in useTheme hook (react-native-elements#3643

)
haeniya · Sep 21, 2022 · 64a1160 · 64a1160
1 parent 45d0058
commit 64a1160
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 21 deletions.
diff --git a/packages/themed/src/config/ThemeProvider.tsx b/packages/themed/src/config/ThemeProvider.tsx
@@ -1,4 +1,4 @@
-import React, { useCallback, useContext } from 'react';
+import React, { useCallback, useContext, useMemo } from 'react';
 import deepmerge from 'deepmerge';
 import { Colors, lightColors, darkColors } from './colors';
 import {
@@ -146,31 +146,24 @@ interface UseTheme {
 }
 
 export const useTheme = (): UseTheme => {
-  const {
-    theme: { components, ...restTheme },
-    replaceTheme,
-    updateTheme,
-  } = useContext(ThemeContext);
-
-  return {
-    theme: restTheme,
-    replaceTheme,
-    updateTheme,
-  };
+  return useContext(ThemeContext);
 };
 
 export const useThemeMode = () => {
-  const {
-    updateTheme,
-    theme: { mode },
-  } = useTheme();
+  const themeContext = useContext(ThemeContext);
 
   const setMode = useCallback(
     (colorMode: ThemeMode) => {
-      updateTheme({ mode: colorMode });
+      themeContext?.updateTheme({ mode: colorMode });
     },
-    [updateTheme]
+    [themeContext]
   );
 
-  return { mode, setMode };
+  return useMemo(
+    () => ({
+      mode: themeContext?.theme?.mode,
+      setMode,
+    }),
+    [setMode, themeContext?.theme?.mode]
+  );
 };
diff --git a/website/docs/customization/1.themeprovider.mdx b/website/docs/customization/1.themeprovider.mdx
@@ -163,10 +163,11 @@ const theme = createTheme({
 
 const ColorScheme = ({ children }) => {
   const colorMode = useColorScheme();
-  const { theme, setThemeMode } = useTheme();
+  const { theme } = useTheme();
+  const { setMode } = useThemeMode();
 
   React.useEffect(() => {
-    setThemeMode(colorMode);
+    setMode(colorMode);
   }, [colorMode]);
 
   return (