src/net_info: Bug fix #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalmjasper
force-pushed
the
net_info_fixed
branch
from
9bff978
to
d407b8d
Compare
Geertiebear
reviewed
Sep 17, 2024
| @@ -47,3 +47,5 @@ struct AF_XDP_OPTS { | |||
|
|
|||
| using NICType = EthRxTx<NIC_OPTS>; | |||
|
|
|||
| // template class EthRxTx<AF_XDP_OPTS>; | |||
| close(sock); | ||
|
|
||
| if (!routes_map.contains(iface)) { | ||
| spdlog::warn("Cannot get routes for {}, returning empty RouteInfo", iface); | ||
| return net_info::RouteInfo{.if_name = iface}; |
There was a problem hiding this comment.
What bug does this fix?
There was a problem hiding this comment.
Can't run the tool on a bare NIC for testing with AF_XDP otherwise. Needs to be connected to a network interface
There was a problem hiding this comment.
But then you need to provide some extra details right? Like gateway mac and source ip
| std::array<typename RTEMbufArray<Elem, N, type>::pointer, N> ptrs; | ||
| auto ptr = reinterpret_cast<void **>(ptrs.data()); | ||
| auto res = rte_ring_dequeue_burst(ptr_, ptr, num, nullptr); | ||
| std::array<typename RTEMbufArray<Elem, N, type>::pointer, N> objs; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.