Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing ENDMDL on HETATM in pdb_tidy #161

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Adds missing ENDMDL on HETATM in pdb_tidy #161

merged 2 commits into from
Dec 13, 2023

Conversation

joaomcteixeira
Copy link
Member

Solves #160

All previous tests are passing on my machine.

Well noticed, @amjjbonvin

@joaomcteixeira joaomcteixeira self-assigned this Dec 12, 2023
@joaomcteixeira joaomcteixeira linked an issue Dec 12, 2023 that may be closed by this pull request
pdb_tidy discards ENDMDL statements for HETATM ensembles #160
Closed
JoaoRodrigues
JoaoRodrigues approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@JoaoRodrigues JoaoRodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks João!

@joaomcteixeira
Copy link
Member Author

Thx!
@JoaoRodrigues action with py27 is failing but tests pass locally on my side with py27. Should we merge nonetheless?

mgiulini
mgiulini approved these changes Dec 13, 2023
View reviewed changes
Copy link

@mgiulini mgiulini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@joaomcteixeira joaomcteixeira merged commit 97de57d into haddocking:master Dec 13, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgiulini mgiulini mgiulini approved these changes

@JoaoRodrigues JoaoRodrigues JoaoRodrigues approved these changes

@amjjbonvin amjjbonvin Awaiting requested review from amjjbonvin

Assignees

@joaomcteixeira joaomcteixeira

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pdb_tidy discards ENDMDL statements for HETATM ensembles
3 participants
@joaomcteixeira @JoaoRodrigues @mgiulini