-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
analysis docs #681
analysis docs #681
Conversation
created doc for analysis
added box plot link
docs/tutorials/analysing_runs.md
Outdated
haddock3-analyse -r my-run-folder -m 2 5 6 -p reference_fname my_ref.pdb receptor_chain F | ||
``` | ||
|
||
Here the `-p` key tells the code that you are about to insert caprieval parameters, whose name should match the parameter name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameter name and corresponding value must be separated by space.
run_dir = "my-run-folder" | ||
|
||
# postprocess the run | ||
postprocess = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open question (that should be discussed):
shoudn't the value of the postprocess
parameter be true by default ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I think we discussed this with @amjjbonvin in the past and decided to set it to false by default, but I am more than open to re-discuss it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about placing the post-processing
section in first ? and then explaining the haddock3-analyse
and haddock3-traceback
?
Also adding internal links to the 3 sections that will be later presented ?
Dedicated analyses modules are made available, allowing to investigate the different steps of a HADDOCK3 workflow, even after it has been completed.
* [Post-processing](#the-postprocess-option)
* [Analyse](#haddock3-analyse)
* [Traceback](#haddock3-traceback)
``` ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree about the bindings but I would not change the order..it's complicated to describe the postprocess option without saying anything about the commands it executes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I would not modify the titles, I think that it's beneficial to have "haddock3-analyse" as a title for the user
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
=======================================
Coverage 74.78% 74.78%
=======================================
Files 113 113
Lines 7948 7948
=======================================
Hits 5944 5944
Misses 2004 2004
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you are proposing is user documentation, but the docs that are built automatically are related to code documentation.
I would not mix these two in the same codebase because user access can be limited by documentation build issues that are unrelated to the information provided in those docs.
User information should fit together with the rest of the material at bonvinlab.org. However this is not for me to decide since I'm not the lead on the project.
I know this is user documentation, of course. It was thought as a technical guide for people that want to approach the haddock3-specific analysis, as it's done in the other docs/tutorials/ markdown files. |
moved to haddocking/haddocking.github.io#677 |
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:
tox
tests pass. Runtox
command inside the repository folder-test.cfg
examples execute without errors. Insideexamples/
runpython run_tests.py -b
Closes #628 by adding a new .md file in the
docs/tutorials
folder, namelyanalysing_runs.md
. It describes the basic usage ofhaddock3-analyse
andhaddock3-traceback
. I also added a couple of example plots forhaddock3-analyse