-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update classes to prevent cutoff of left side of project table #1934
update classes to prevent cutoff of left side of project table #1934
Conversation
This fix introduces another problem when you use the horizontal scroll bar and scroll to the right, the page is wider than the headers at the top of the page: I think what we probably need to do is enclose the gird in a div that allows horizontal scrolling, instead of having the scroll bar apply to the whole page. This way, only the grid itself scrolls horizontally. Others mentioned last week that the page heading and all the stuff just above the grid should stay on-screen regardless of scroll position. Bonnie also mentioned that the column headings in the grid should be frozen (i.e. not change vertical position if you scroll vertically). Though I don't think anybody created an issue for this, it might (or might not) be easy to piggyback on this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces another problem - see my comment on the PR with a screen shot.
…into 1927-project-table-cutoff-at-narrow-screens
…into 1927-project-table-cutoff-at-narrow-screens
…her pages in the site
…into 1927-project-table-cutoff-at-narrow-screens
@entrotech I am working on two options:
|
@entrotech Thank you for merging this PR. You may have noticed that at smaller screen sizes, some features (of the toolbar above the table) are cut off, and I believe that some design and implementation changes should be considered to make those elements more responsive. I have an alternative solution in which scrolling is done at the page level, and the problem depicted in #1934 (comment) is resolved by the use of CSS and JavaScript to dynamically adjust the width of the various elements to align. |
|
Fixes #1927
What changes did you make?
body
element in<ProjectTable>
, to prevent page-wide scrollingdiv.tableContainer
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied