Add .toLowerCase db query #1811
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note/QuestionI noticed I could create new users with invalid emails and that there is no created issue for this bug. I originally created a fix but removed it incase I'm not supposed to handle additional bugs this way. Should I submit a new issue instead of adding the fix here? |
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1464
What changes did you make and why did you make them ?
.toLowerCase()across front-end files that were calling or creating emails. If you try to sign in with various uppercase and lowercase letters, your email is now still recognized; New users emails should all resolve to lowercase to help stop duplicates.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Screen Capture - Login Example
First example shows fix, second example shows bugScreen.Recording.2024-11-11.at.4.10.08.PM.mov