-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtered permissions data comp #1808
base: development
Are you sure you want to change the base?
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jng34, the functionality of the "User Permission Search" page seems fine. The overall code looks good as well. I just added a few comments.
client/src/pages/UserAdmin.jsx
Outdated
return <UserPermissionSearch users={users} setUserToEdit={setUserToEdit} />; | ||
// return <UserManagement users={users} setUserToEdit={setUserToEdit} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding, there shouldn't be any changes to the "UserAdmin.jsx" file. Refer to the mockup Low-fi mockups created by Bonnie / Jack - see page 1.
So, the "UserPermissionSearch" component should render when clicking on the "User Permission Search" button on the "Users" page.
But, it looks like we do need the useState hooks and functions in the UserAdmin page (or a similar structure) to handle the User Permission Search. Not sure if creating a new page with the same code structure would be a good approach. But, that code is probably needed to handle the filter and make each data element renders a link to the associated user profile, which is part of #1754.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to change it back to UserManagement
when testing the code earlier, so thank you for catching that.
I left the props users
and setUserToEdit
in the UserPermissionSearch
component as placeholders for now so they can be used for integration with the filter permissions data component (#1754).
If there should be changes in the props that are appropriate for the filter component, just let me know.
@trillium, can you confirm that the accessLevel in the dummy data object should be "admin" or "projectLead"?
From the
It looks like we have this
|
Fixes #1752
What changes did you make and why did you make them ?
/users/permission-search/admin
and/users/permission-search/projects
corresponding to each search tabAdmins
will be filtered alphabetically by first name andProject Leads
will be filtered alphabetically by Project name and by then first nameScreenshots of Proposed Changes Of The Website
Visuals before changes are applied
Visuals after changes are applied