Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt ValidatedTextField to accept custom validation functions #1789

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

angela-lee1
Copy link
Member

Fixes #1484

What changes did you make and why did you make them ?

  • Adapt ValidatedTextField to apply custom validations into the validate portion of the register function from react-hook-form

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

[image](
Screenshot 2024-10-14 at 1 35 26 PM
)

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b angela-lee1-accept-custom-validation-functions development
git pull https://github.com/angela-lee1/VRMS.git accept-custom-validation-functions

Copy link
Member

@pluto-bell pluto-bell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela-lee1 it looks like one of your changes caused a change on styling as well.

Before and After Notice how the form was previously encapsulated by the same grey background as the section above it and included different padding/margin. Screenshot 2024-11-10 at 12 03 12 PM Screenshot 2024-11-10 at 12 03 28 PM
Potential Cause It looks like the `form` component got removed as a child from a `div` component with a `MuiBox-css` class. Notice how the `form` component was previously nested Screenshot 2024-11-10 at 12 07 11 PM Screenshot 2024-11-10 at 12 10 00 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt ValidatedTextField to accept custom validation functions
2 participants