Add trackBy to optimize performance

hackerspace-bootstrap · Oct 16, 2016 · 7a0dd43 · 7a0dd43
1 parent c614fa0
commit 7a0dd43
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/script/lib/controllers/index/index.html b/src/script/lib/controllers/index/index.html
@@ -7,7 +7,10 @@
     <div class="col-xs-12">
         <h3 translate>indexActiveUser</h3>
         <ul class="user-list clearfix">
-            <li ng-repeat="user in users | filter:isActiveUser | orderBy:'name'" ng-click="userClick(user.id)" class="col-xs-2 panel panel-default" title="{{user.name}}">
+            <li ng-repeat="user in users | filter:isActiveUser | orderBy:'name' track by user.id"
+                ng-click="userClick(user.id)"
+                class="col-xs-2 panel panel-default"
+                title="{{user.name}}">
                 <div class="name">{{user.name}}</div>
                 <div class="balance" ng-class="user.balance < -0.009 ? 'negative' : ''">{{user.balance | number:2}} {{currency}}</div>
             </li>
@@ -19,7 +22,10 @@ <h3 translate>indexActiveUser</h3>
     <div class="col-xs-12">
         <h3 translate>indexInactiveUser</h3>
         <ul class="user-list clearfix">
-            <li ng-repeat="user in users | filter:isInactiveUser | orderBy:'name'" ng-click="userClick(user.id)" class="col-xs-2 panel panel-default" title="{{user.name}}">
+            <li ng-repeat="user in users | filter:isInactiveUser | orderBy:'name' track by user.id"
+                ng-click="userClick(user.id)"
+                class="col-xs-2 panel panel-default"
+                title="{{user.name}}">
                 <div class="name">{{user.name}}</div>
                 <div class="balance" ng-class="user.balance < 0 ? 'negative' : ''">{{user.balance | number:2}} {{currency}}</div>
             </li>

diff --git a/src/script/lib/controllers/transaction/transaction.html b/src/script/lib/controllers/transaction/transaction.html
@@ -27,7 +27,7 @@ <h2><span translate translate-value-name="{{user.name}}">transactionForUser</spa
                     </tr>
                 </thead>
                 <tbody>
-                    <tr ng-repeat="transaction in transactions | orderBy:'-id'">
+                    <tr ng-repeat="transaction in transactions | orderBy:'-id' track by transaction.id">
                         <td>{{transaction.createDate | localtime}}</td>
                         <td class="balance" ng-class="transaction.value < 0 ? 'negative' : ''">{{transaction.value|number:2}} {{currency}}</td>
                     </tr>