Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pill cluster to not always use plural of doubloon #804

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

truekas
Copy link
Contributor

@truekas truekas commented Nov 17, 2024

if there is 1 doubloon available, return "Doubloon" else return "Doubloons"

Copy link

vercel bot commented Nov 17, 2024

@truekas is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@maxwofford maxwofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'll merge this, but want to refactor using

export default function pluralize(count, singular, includeCount = true) {
?

@maxwofford
Copy link
Member

I just pushed a formatting fix. Make sure to run bun run fmt before committing in the future!

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
high-seas ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 2:00pm

@maxwofford maxwofford merged commit a643718 into hackclub:main Nov 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants