-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard-Code tutorials to avoid the tutorial failing #756
Hard-Code tutorials to avoid the tutorial failing #756
Conversation
This fixes hackclub#738. We hard-code the projects for tutorial mode so in-case the matchup generator dies for some reason, we can still complete the tutorial.
@scooterthedev is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
Great start! I'll test this once you're ready. Can you make sure we have some good clear projects that'll set people's expectations when voting instead of just the hack club site repo? |
@maxwofford @scooterthedev There are two projects already in the base for this purpose, called Simple Numbers and Wiggly Dragon Title: Simple Numbers Title: Wiggly dragon!!! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Oh perf! @scooterthedev can you set the project to that? I've also gone ahead and approved the vercel deployment so you can test it with a #temp-email account! |
updateDescription: null, | ||
reshippedFromId: null, | ||
reshippedToId: null, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, why is this being added @scooterthedev?
losses: [], | ||
losses_adjustments: 0, | ||
autonumber: 0, | ||
entrant__slack_id: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need all these fields like wins, wins_adjustments, rating, etc? Are these there just because those fields are there on what we currently get from the API?
@scooterthedev heads-up I left a few questions in comments |
Closed after moving the changes to #849! |
This fixes #738. We hard-code the projects for tutorial mode so in-case the matchup generator dies for some reason, we can still complete the tutorial.