Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-Code tutorials to avoid the tutorial failing #756

Closed

Conversation

scooterthedev
Copy link
Member

This fixes #738. We hard-code the projects for tutorial mode so in-case the matchup generator dies for some reason, we can still complete the tutorial.

This fixes hackclub#738. We hard-code the projects for tutorial mode so in-case the matchup generator dies for some reason, we can still complete the tutorial.
Copy link

vercel bot commented Nov 13, 2024

@scooterthedev is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@maxwofford
Copy link
Member

Great start! I'll test this once you're ready. Can you make sure we have some good clear projects that'll set people's expectations when voting instead of just the hack club site repo?

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
high-seas ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 6:58pm

@maxwofford
Copy link
Member

Oh perf! @scooterthedev can you set the project to that? I've also gone ahead and approved the vercel deployment so you can test it with a #temp-email account!

updateDescription: null,
reshippedFromId: null,
reshippedToId: null,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, why is this being added @scooterthedev?

losses: [],
losses_adjustments: 0,
autonumber: 0,
entrant__slack_id: [],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all these fields like wins, wins_adjustments, rating, etc? Are these there just because those fields are there on what we currently get from the API?

@polytroper
Copy link
Collaborator

@scooterthedev heads-up I left a few questions in comments

@maxwofford
Copy link
Member

Closed after moving the changes to #849!

@maxwofford maxwofford closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard-code tutorial matchup
3 participants