Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-235: Fix Documentation not showing up on the website #343

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

Amalicia
Copy link
Contributor

This PR adjusts the method scopes in order to allow Scaladoc to correctly generate documentation.

Description

TODO

Related Issue and dependencies

How Has This Been Tested?

  • This pull request contains appropriate tests?:
    • YES / NO
    • Something relevant to mention

@github-actions github-actions bot added spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 labels Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #343 (a463104) into main (5fe194b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files          62       62           
  Lines        1249     1249           
  Branches       18       18           
=======================================
  Hits         1219     1219           
  Misses         30       30           
Flag Coverage Δ
spark-2.4.x 94.66% <ø> (ø)
spark-3.0.x 96.74% <ø> (ø)
spark-3.1.x 97.48% <ø> (ø)
spark-3.2.x 97.70% <ø> (ø)
spark-3.3.x 97.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/main/scala/doric/sem/JoinOps.scala 100.00% <ø> (ø)
...c/main/scala/doric/syntax/AggregationColumns.scala 100.00% <ø> (ø)
...ore/src/main/scala/doric/syntax/ArrayColumns.scala 100.00% <ø> (ø)
...re/src/main/scala/doric/syntax/BinaryColumns.scala 100.00% <ø> (ø)
...e/src/main/scala/doric/syntax/BooleanColumns.scala 100.00% <ø> (ø)
...re/src/main/scala/doric/syntax/CommonColumns.scala 100.00% <ø> (ø)
...rc/main/scala/doric/syntax/ControlStructures.scala 100.00% <ø> (ø)
core/src/main/scala/doric/syntax/DStructs.scala 100.00% <ø> (ø)
core/src/main/scala/doric/syntax/DateColumns.scala 100.00% <ø> (ø)
...c/main/scala/doric/syntax/LiteralConversions.scala 100.00% <ø> (ø)
... and 13 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe194b...a463104. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 12, 2023

:octocat: This is an auto-generated comment created by:

Actor Triggering actor Sender
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
Triggered by:

Test summary report 📊

Spark version testing
2.4.1 623 passed, 2 skipped
2.4.2 623 passed, 2 skipped
2.4.3 623 passed, 2 skipped
2.4.4 623 passed, 2 skipped
2.4.5 623 passed, 2 skipped
2.4.6 624 passed, 2 skipped
2.4.7 624 passed, 2 skipped
2.4 624 passed, 2 skipped
3.0.0 674 passed, 2 skipped
3.0.1 674 passed, 2 skipped
3.0.2 674 passed, 2 skipped
3.0 674 passed, 2 skipped
3.1.0 702 passed, 2 skipped
3.1.1 702 passed, 2 skipped
3.1.2 702 passed, 2 skipped
3.1 702 passed, 2 skipped
3.2.0 706 passed, 2 skipped
3.2.1 706 passed, 2 skipped
3.2.2 706 passed, 2 skipped
3.2 706 passed, 2 skipped
3.3.0 706 passed, 2 skipped
3.3.1 706 passed, 2 skipped
3.3 706 passed, 2 skipped

@eruizalo eruizalo force-pushed the bug/issue-235-docs-not-showing branch from 406947b to a463104 Compare April 22, 2023 17:23
@eruizalo eruizalo marked this pull request as ready for review April 25, 2023 09:05
@eruizalo eruizalo requested a review from a team as a code owner April 25, 2023 09:05
@eruizalo eruizalo merged commit 1deb9be into hablapps:main Apr 25, 2023
@Amalicia Amalicia deleted the bug/issue-235-docs-not-showing branch April 25, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report]: some API website links are not working
3 participants