feat: [-] delete round no args due to ambiguity

hablapps · Aug 12, 2023 · ac5a787 · ac5a787
1 parent 1f144e7
commit ac5a787
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/core/src/main/scala/doric/syntax/NumericColumns.scala b/core/src/main/scala/doric/syntax/NumericColumns.scala
@@ -576,15 +576,6 @@ protected trait NumericColumns {
       */
     def floor: LongColumn = column.elem.map(f.floor).toDC
 
-    /**
-      * Returns the value of the column e rounded to 0 decimal places with HALF_UP round mode
-      *
-      * @todo decimal type
-      * @group Numeric Type
-      * @see [[org.apache.spark.sql.functions.round(e:org\.apache\.spark\.sql\.Column)* org.apache.spark.sql.functions.round]]
-      */
-    def round: DoricColumn[T] = column.elem.map(f.round).toDC
-
     /**
       * Round the value to `scale` decimal places with HALF_UP round mode
       * if `scale` is greater than or equal to 0 or at integral part when `scale` is less than 0.

diff --git a/core/src/test/scala/doric/syntax/NumericOperationsSpec.scala b/core/src/test/scala/doric/syntax/NumericOperationsSpec.scala
@@ -531,7 +531,7 @@ trait NumericOperationsSpec
         testDoricSparkDecimals[T, T](
           List(Some(-1.4f), Some(0.7f), Some(1.0f), None),
           List(Some(-1.0f), Some(1.0f), Some(1.0f), None),
-          _.round,
+          _.round(0.lit),
           f.round
         )
       }