Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make includable in other content types #26

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

otacke
Copy link
Contributor

@otacke otacke commented Jul 20, 2020

Currently, Speak the Words cannot be included in e.g. Course Presentation, because it doesn't set default values and would crash when adding it in the editor. Also, it doesn't fully implement the question type contract, so scores would not be reported on Course Presentations's summary slide.

When merged in, Speak the Words will

  • set default values, so it could be used in Course Presentation
  • fully implement the question type contract including getXAPIData(), so it reports scores etc.

hoangbinh added a commit to hoangbinh/h5p-speak-the-words that referenced this pull request Sep 24, 2023
- Merge pull request h5p#26 (thanks otacke)
- Fix error not loading in Course Presentation
- increase patchVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant