ensure that email attribute is set

h44z · May 17, 2021 · d165fc0 · d165fc0
1 parent cadbe4a
commit d165fc0
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/internal/server/ldapsync.go b/internal/server/ldapsync.go
@@ -113,6 +113,11 @@ func (s *Server) disableMissingLdapUsers(ldapUsers []ldap.RawLdapData) {
 
 func (s *Server) updateLdapUsers(ldapUsers []ldap.RawLdapData) {
 	for i := range ldapUsers {
+		if ldapUsers[i].Attributes[s.config.LDAP.EmailAttribute] == "" {
+			logrus.Tracef("skipping sync of %s, empty email attribute", ldapUsers[i].DN)
+			continue
+		}
+
 		user, err := s.users.GetOrCreateUserUnscoped(ldapUsers[i].Attributes[s.config.LDAP.EmailAttribute])
 		if err != nil {
 			logrus.Errorf("failed to get/create user %s in database: %v", ldapUsers[i].Attributes[s.config.LDAP.EmailAttribute], err)