Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple updates , use position instead of center, nexusformat notebook #192

Merged
merged 22 commits into from
Nov 25, 2024
Merged

multiple updates , use position instead of center, nexusformat notebook #192

merged 22 commits into from
Nov 25, 2024

Conversation

vedina
Copy link
Contributor

@vedina vedina commented Nov 18, 2024

xcalibration updates

  • use position field from FitPeakResults (if available) , important for LaserZeroing
  • set bound_centers_to_group=True]
    demo notebooks update
  • xcalibration demo.ipynb
  • nexusformat
  • demo ploomber workflow

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src/ramanchada2/misc/types
  fit_peaks_result.py
  src/ramanchada2/protocols/calibration
  calibration_component.py
  calibration_model.py
  xcalibration.py 83-95, 182, 466-468
  src/ramanchada2/spectrum/peaks
  fit_peaks.py
  tests/protocols
  test_calibrationmodel.py 147-148, 181, 196-198, 257
Project Total  

This report was generated by python-coverage-comment-action

@georgievgeorgi georgievgeorgi mentioned this pull request Nov 19, 2024
Open
@kerberizer kerberizer merged commit d7b4e2b into main Nov 25, 2024
5 checks passed
@kerberizer kerberizer deleted the oranchada-related-fix branch November 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgievgeorgi georgievgeorgi georgievgeorgi approved these changes

Assignees

@kerberizer kerberizer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vedina @georgievgeorgi @kerberizer