-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative Ne/Si calibration #182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgievgeorgi
force-pushed
the
dev_gg
branch
from
November 1, 2024 12:58
6b029c2
to
2ad7317
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
|
def neon_calibration(ne_cm_1: Spectrum,
wl: Literal[514, 532, 633, 785]):
def silicon_calibration(si_nm: Spectrum,
wl: Literal[514, 532, 633, 785]):
def neon_silicon_calibration(ne_cm_1: Spectrum,
si_cm_1: Spectrum,
wl: Literal[514, 532, 633, 785]): All these functions return splines, which later can be applied with cal = neon_silicon_calibration(ne_cm_1, si_cm_1, wl)
ps_cal = ps.scale_xaxis_fun(cal) The calibration is not yet saveable using standard rc2 tools. |
georgievgeorgi
force-pushed
the
dev_gg
branch
from
November 4, 2024 18:27
2ad7317
to
6d884ae
Compare
@vedina, all tests are passing now. The disabled tests in |
vedina
approved these changes
Nov 5, 2024
ok, let's merge @kerberizer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.