Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Ne/Si calibration #182

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Alternative Ne/Si calibration #182

merged 5 commits into from
Nov 5, 2024

Conversation

georgievgeorgi
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 1, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/ramanchada2/misc/utils
  argmin2d.py 30, 78
  src/ramanchada2/protocols
  calib_ne_si_argmin2d_iter_gg.py 1-44
  src/ramanchada2/spectrum
  spectrum.py 56
  src/ramanchada2/spectrum/calibration
  by_deltas.py 113-118, 130-142, 263-294
  src/ramanchada2/spectrum/creators
  from_delta_lines.py 45, 47
Project Total  

This report was generated by python-coverage-comment-action

@vedina
Copy link
Contributor

vedina commented Nov 4, 2024

  • haven't tested the code yet
  • is there an example how one saves/loads the calibration and applies it to other spectra without deriving it every time

@georgievgeorgi
Copy link
Contributor Author

def neon_calibration(ne_cm_1: Spectrum,
                     wl: Literal[514, 532, 633, 785]):

def silicon_calibration(si_nm: Spectrum,
                        wl: Literal[514, 532, 633, 785]):

def neon_silicon_calibration(ne_cm_1: Spectrum,
                             si_cm_1: Spectrum,
                             wl: Literal[514, 532, 633, 785]):

All these functions return splines, which later can be applied with scale_xaxis_fun():

cal = neon_silicon_calibration(ne_cm_1, si_cm_1, wl)
ps_cal = ps.scale_xaxis_fun(cal)

The calibration is not yet saveable using standard rc2 tools.

@georgievgeorgi
Copy link
Contributor Author

@vedina, all tests are passing now. The disabled tests in calibrationmodel are enabled now.

@vedina vedina self-requested a review November 5, 2024 05:23
@vedina
Copy link
Contributor

vedina commented Nov 5, 2024

ok, let's merge @kerberizer

@kerberizer kerberizer merged commit dc06d00 into main Nov 5, 2024
5 checks passed
@kerberizer kerberizer deleted the dev_gg branch November 5, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants