Implement concurrent downloads #1701
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1701 +/- ##
=====================================
Coverage 94.3% 94.3%
=====================================
Files 239 239
Lines 18560 18567 +7
=====================================
+ Hits 17517 17525 +8
+ Misses 1043 1042 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| detector, | ||
| start, | ||
| end, | ||
| nthreads=10, |
There was a problem hiding this comment.
Can you please add this option to the 'upstream' TimeSeriesBase.fetch_open_data method, or at least document the keyword argument there.
And also, probably somewhere in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs benchmarking. Perhaps no benefit at this time (but no downside to have the functionality).