feat: make enter visual timeline mode not clear selection,

add new binding <M-v> which does old behaviour of clearing timeline selection
gwatcha · Sep 7, 2020 · a6188c3 · a6188c3
1 parent c928c90
commit a6188c3
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/definitions/defaults/actions.lua b/definitions/defaults/actions.lua
@@ -431,6 +431,8 @@ return {
       SetModeNormal = lib.state.setModeNormal,
       PasteItemFxChain = {"_S&M_COPYFXCHAIN9", prefixRepetitionCount=true},
       SetModeVisualTimeline = lib.state.setModeVisualTimeline,
+      ClearSelectedTimeline = custom.clearSelectedTimeline,
+      ClearTimelineSelectionAndSetModeVisualTimeline = {"ClearSelectedTimeline", "SetModeVisualTimeline"},
       SetModeVisualTrack = lib.state.setModeVisualTrack,
       SetModeRecord = lib.state.setModeRecord,
       SetProjectTimebaseToBeatsPosLengthAndRate = "_SWS_AWTBASEBEATALL",

diff --git a/definitions/defaults/global.lua b/definitions/defaults/global.lua
@@ -35,7 +35,6 @@ return {
   },
   timeline_selector = {
     ["~"] = "MarkedRegion",
-    ["v"] = "TimeSelection",
     ["!"] = "LoopSelection",
     ["<S-right>"] = "NextRegion",
     ["<S-left>"] = "PrevRegion",
@@ -76,6 +75,7 @@ return {
     ["<C-z>"] = "ZoomUndo",
     ["<C-Z>"] = "ZoomRedo",
     ["v"] = "SetModeVisualTimeline",
+    ["<M-v>"] = "ClearTimelineSelectionAndSetModeVisualTimeline",
     ["<C-SPC>"] = "ToggleViewMixer",
     ["<ESC>"] = "Reset",
     ["<return>"] = "StartStop",

diff --git a/definitions/defaults/main.lua b/definitions/defaults/main.lua
@@ -25,7 +25,6 @@ return {
   },
   track_selector = {
     ["'"] = "MarkedTracks",
-    ["V"] = "Selection",
     ["c"] = "FolderChildren",
     ["F"] = "FolderParent",
     ["F"] = "Folder",

diff --git a/internal/custom_actions/custom_actions.lua b/internal/custom_actions/custom_actions.lua
@@ -36,6 +36,11 @@ function custom_actions.setMidiGridDivision()
   end
 end
 
+function custom_actions.clearSelectedTimeline()
+  local current_position = reaper.GetCursorPosition()
+  reaper.GetSet_LoopTimeRange(true, false, current_position, current_position, false)
+end
+
 function custom_actions.setGridDivision()
   local division = getUserGridDivisionInput()
   if division then

diff --git a/internal/library/state.lua b/internal/library/state.lua
@@ -1,4 +1,5 @@
 local state_interface = require('state_machine.state_interface')
+local config = require('definitions.config')
 
 local state = {}
 
@@ -19,10 +20,7 @@ function state.setModeVisualTrack()
 end
 
 function state.setModeVisualTimeline()
-  local current_position = reaper.GetCursorPosition()
-  reaper.GetSet_LoopTimeRange(true, false, current_position, current_position, false)
   state_interface.setMode('visual_timeline')
-
   if state_interface.getTimelineSelectionSide() == 'left' then
     state_interface.setTimelineSelectionSide('right')
   end