various improvements: compatibility with windows, tsconfig file can be specified, tsconfig file allows comments, args can be passed to tsc #4
Conversation
barroudjo
commented
Apr 27, 2020
•
barroudjo
commented
- compatibility with windows
- tsconfig file can be specified
- tsconfig file allows comments
- args (other than files of course, as they are already put in the temp tsconfig) are passed to tsc
| const filesToCheck = args._.filter(file => /\.(ts|tsx)$/.test(file)) | ||
| const argvCleaned = process.argv.slice(2) | ||
| const args = yargsParser(argvCleaned) | ||
| const filesToCheck = args._.filter(file => /\.(ts|tsx)$/.test(file)) // but what about globs ? |
There was a problem hiding this comment.
Do you believe we should use glob instead of regex here? What would be the benefit?
There was a problem hiding this comment.
No , it's just that the file argument to the tsc cli can be a glob, as the example here shows:
tsc src/*.tsAnd we should detect them because they should not be put in the files property of the temporary tsconfig, but in the include property.
I left that for later, but I put a comment to at least have the maintainers be aware of the potential issue ;-).
|
Are you OK with merging this pull request ? It'd be great to use this library, instead of my fork of it ;-) |
@barroudjo Sorry for the delay. I'll try to get this merged today. EDIT: I'll wait for your take on #6 (comment). |
|
Hey @barroudjo. I wanted to change some minor things in your PR but I think I'm not able to do that, so I just created a new PR derived from yours: #7. Can you check if it covers everything you need and also test it on Windows please? P.S.: if you know how I could edit your PR without creating a new one, please let me know. |
|
Hey all - Any idea when this or #7 will get merged/released? Just coming across this package and need to pass additional arguments. Thanks! |
|
@barroudjo @jamesopti I've just merged #7 and released v1.1.0. |
