forked from activemerchant/active_merchant
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge netgíró #1
Open
saevarom
wants to merge
123
commits into
guitarparty:master
Choose a base branch
from
overcastsoftware:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurrencyExponent were not being set while performing transactions with saved profiles. This commit fixes that.
Add bitpay return, fix return_url mapping
This reverts commit 75744b7. Conflicts: CHANGELOG
Ipay88: Use the amount in dollars instead of cents to generate the signature
Stripe: Ignore tthe customer option when paying with a creditcard.
…_field_fix Orbital mandatory field fix
Also fixes a nil being passed to CGI.unescape. Closes activemerchant#890.
…Response and passed the card_uri and account_uri back in authorization
changed Balanced store card to be an ActiveMerchant::Billing::Response
fix documented parameter name
Payu(Paisa) refactor
[pin] Use CreditCard#name
Fix spelling mistakes.
Fixes typos in AuthorizeNetCimGateway comments
…elector-error-handling Refactor gateway selector error handling
Refactor IPay88 to follow correct integration using Notification
It was not working correctly for single items.
Fixes a problem where merchant descriptor wasn't being handled for capture and authorization requests. Closes activemerchant#936.
Merchant Warrior docs say the transactionProduct attribute is the description: http://cl.ly/image/0D0E3u3k1417/content.png http://dox.merchantwarrior.com/files/MWE%20API.pdf Use options[:description] like many other gateways to abstract this away so we're not passing in custom options for each gateway. Closes activemerchant#945.
Before: Specify the description for the purchase or authorization using the options[:description] || options[:email]. After: Use options[:description] for description. Use metadata for the email. Keep the 2 options separate as the Stripe docs suggest: https://stripe.com/docs/api#metadata Closes activemerchant#946.
This allows folks to use either billing_address or address just like many other gateways do. Previously our Merchant Warrior support ignored billing_address. Closes activemerchant#948.
Handle comma-delimited amounts with Valitor
Provides support for passing valid and invalid account numbers to the bogus gateway and returning relevant error messages. A valid account number is any account number that ends with 1. An invalid account number is any account number that ends with 2. Any object that responds to `account_number` will be treated as a check. Note, because ActiveMerchant::Billing::Check has a `number` attribute in addition to `account_number`, priority is given to `number` for backwards compatibility. CREDIT_ERROR_MESSAGE was removed because it was the same as ERROR_MESSAGE. Closes activemerchant#944.
This replaces Rapid 3.0 with Rapid 3.1, which is a much more appropriate API for direct calls. In particular, all calls are now a single remote vs. the 2+ that most calls required in 3.0. 3.1 support must be enabled on a per-account basis on the eWay side. Close activemerchant#958.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.