Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Mixin for common class resolving #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Mixin for common class resolving #2

wants to merge 1 commit into from

Conversation

Fox2Code
Copy link

This PR Change ClassWriter to use the Mixin Implementation instead of the ASM Implementation

Mixin implementation don't load classes to resolve common classes but compare the unloaded bytecode

It completely prevent any ClassCircularityError by making COMPUTE_FRAMES no longer call loadClass making it a lot safer than the current implementation of ClassWriter in gudASM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Fox2Code