Delete Snyk workflow - replaced by submitting sbt dependencies to GitHub #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further to #475, we are now removing Snyk from this project, so we can rely on one source of truth for dependency-vulnerability information. In this repo, we would find GitHub's dependency-vulnerability information at: https://github.com/guardian/play-secret-rotation/security/dependabot This does seem to miss some information that we could find in a Snyk report - ie the dependency-path that introduces the dependency. For instance this Snyk issue provides "Detailed paths \ Introduced through" information: https://app.snyk.io/org/scala-guild/project/10018236-f7b7-416e-99d4-196d1c2f3d23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to #475, we are now removing Snyk from this project, so we can rely on one source of truth for dependency-vulnerability information.
In this repo, we would find GitHub's dependency-vulnerability information at:
https://github.com/guardian/play-secret-rotation/security/dependabot
This does seem to miss some information that we could find in a Snyk report - ie the dependency-path that introduces the dependency. For instance this Snyk issue provides "Detailed paths \ Introduced through" information:
https://app.snyk.io/org/scala-guild/project/10018236-f7b7-416e-99d4-196d1c2f3d23
cc @guardian/devx-security - are we ok to start removing Snyk workflows if we have already installed the "Update Dependency Graph for SBT" workflow?