Log if tests are running in CI (rather than on local developer laptop) #27709
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change follows on from #26973, I was trying to work out how the Frontend test suite varies its behaviour between running locally on a developer's machine, and running in CI on GitHub Runner (there are some critical differences in behaviour, ie around the test database resources, where missing database resources should *not* be tolerated in CI, but should be freshly downloaded if missing in local development) - I couldn't work out where the `CI="true"` environment variable was coming from, and I thought maybe it wasn't getting set, which was alarming! Charlotte Emms kindly pointed me to the relevant documentation, which explains that the default environment variable `CI` is always set to true in GitHub Runners: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables To make this a little clearer, I'm changing the code now to log an informative statement if we're running the tests in CI.
arelra
approved these changes
Jan 9, 2025
|
Seen on FRONTS-PROD, ADMIN-PROD (merged by @rtyley 11 minutes and 59 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change follows on from #26973 - I was trying to work out how the Frontend test suite varies its behaviour between running locally on a developer's machine, and running in CI on GitHub Runner (there are some critical differences in behaviour, ie around the test database resources, where missing database resources should not be tolerated in CI, but should be freshly downloaded if missing in local development) - I couldn't work out where the
CI="true"environment variable was coming from, and I thought maybe it wasn't being set, which was alarming!@cemms1 kindly pointed me to the relevant documentation, which explains that the default environment variable
CIis always set to true in GitHub Runners.To make this a little clearer, I'm changing the code now to log an informative statement if we're running the tests in CI:
This message does not appear when running locally in a non-CI environment, to avoid exposing developers to unnecessary noise.