Allow preview release process to comment on PRs #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guardian/gha-scala-library-release-workflow#19 introduces support for publishing preview releases, but note this does use the `pull-requests: write` permission in order to comment on the PR to announce that the release has been published - so we need to additionally grant that permission: https://github.com/guardian/gha-scala-library-release-workflow/pull/19/files#r1441589383
rtyley
deleted the
allow-release-process-to-comment-on-prs-to-announce-preview-releases
branch
rtyley
added a commit
to guardian/play-googleauth
that referenced
this pull request
Jan 5, 2024
rtyley
added a commit
to guardian/marley
that referenced
this pull request
Jan 5, 2024
rtyley
added a commit
to guardian/facia-scala-client
that referenced
this pull request
Jan 5, 2024
rtyley
added a commit
to guardian/play-secret-rotation
that referenced
this pull request
Jan 5, 2024
rtyley
added a commit
to guardian/redirect-resolver
that referenced
this pull request
Jan 5, 2024
rtyley
added a commit
to guardian/targeting-client
that referenced
this pull request
Jan 5, 2024
|
Incidentally, to update the 6 or so other repos currently using to make this change, I changed directory into each repo in turn on my local box and executed: ...the script is a little aggressive because it throws away whatever's in your working directory, it should probably clone fresh copies of the repo or something... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guardian/gha-scala-library-release-workflow#19 introduces support for publishing preview releases on PR branches, but note this does use the
pull-requests: writepermission in order to comment on the PR, to announce that the release has been published.Consequently, we need to additionally grant the permission.