Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Groups - Applied optimisations based HEMTT suggestions #212

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

OverlordZorn
Copy link

No description provided.

@b-mayr-1984
Copy link
Member

@OverlordZorn man... this source file

  • hasn't been touched in 7 years (No, ; from @Fusselwurm doesn't count 😛)
  • is ~1800 lines long 😖

Not fun to check the changes.

And those aren't really changing the functionality, right?
They might just change runtime performance?

@dedmen
Copy link
Contributor

dedmen commented Sep 12, 2024

Does this effort make sense, considering HEMTT's optimizer will do most of these tweaks by itself anyway?

@OverlordZorn
Copy link
Author

@OverlordZorn man... this source file

* hasn't been touched in 7 years (No, `;` from @Fusselwurm doesn't count 😛)

* is ~1800 lines long 😖

Not fun to check the changes.

And those aren't really changing the functionality, right? They might just change runtime performance?

I have Dynamic Groups integrated into our unit mod. everytime i build and test something, hemtt threw these "warnings" at me at how much i can improve it.

I added these changes on my side, so hemtt shuts up.

Since i did the work already, i thought "might as well provide it to the OG repo"

@OverlordZorn
Copy link
Author

i run these changes on our units mod and there have been no issues being noted on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants