Structure overhaul to use a pipeline passed an array of consumers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seasew
reviewed
Jan 16, 2022
|
|
||
| for key, item in data.items(): | ||
| # TODO this probably isn't good | ||
| self.network_table.putValue(key, item) |
There was a problem hiding this comment.
maybe use isinstance() ?
Ie:
isinstance(var, bool)
# Put a boolean value in the network table
isinstance(var, float)
# Put a float value in the network table
isinstance(var, list)
# Check type of items in list then put an array in the network table
etc.
I think that as long as we pass only the most essential information from Jetson to robot, then it should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.