Translate this plugin #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds multilingual support to this plugin. Currently supported languages are English, Dutch, and Arabic.
There was a problem hiding this comment.
Hier stond dus al een PR voor open: #14
Dit mag Ramiro lekker reviewen.
|
Godsamme. 😖 @HammenWS kun jij hier komende week akkoord op geven, dan kan ie naar HiiL. Of die andere PR, who cares. |
HammenWS
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
@martijngastkemper Ook even ter info voor jou. Wanneer we json gebruiken in plaats van php voor translation files dan graag de versie van Harmen, want in dat geval is het beter om default values als keys te gebruiken in plaats van een translation 'identifier'.
@harmenjanssen Wel graag de PHP/composer versie aanpassingen en vertalingen van Martijn z'n PR overnemen.
harmenjanssen
force-pushed
the
translate-plugin
branch
from
8f0c965 to
a36b858
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds multilingual support to this plugin.
Currently supported languages are English, Dutch, and Arabic.