Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and clean. Add tests. Use pyproject and lockfile. #44

Merged
merged 19 commits into from
Nov 11, 2024
Merged

Refactor and clean. Add tests. Use pyproject and lockfile. #44

merged 19 commits into from
Nov 11, 2024

Conversation

tyler-romero
Copy link
Member

@tyler-romero tyler-romero commented Nov 8, 2024 •
edited
Loading

Lots of improvements:

  1. much cleaner code, better abstraction around threading. Switch to areparse which is better for a bunch of reasons and more concise.
  2. removed motion detection module in favor of framegrab's
  3. added tests and GHA, good coverage
  4. Use a pyproject and lockfile, repo formatting like an actual python package

@tyler-romero tyler-romero changed the title Refactor and clean. Add tests. Use pyproject. Refactor and clean. Add tests. Use pyproject and lockfile. Nov 8, 2024
@tyler-romero tyler-romero marked this pull request as ready for review November 8, 2024 02:51
@tyler-romero
Copy link
Member Author

Confirmed that the container runs correctly

tyler-romero
tyler-romero commented Nov 8, 2024
View reviewed changes
src/stream/stream.py Outdated
dictConfig(yaml.safe_load(open(fname)))
logger = logging.getLogger(name="groundlight.stream")


Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is the same as the one remove in src/stream.py, its just significantly pared down and so git isnt recognizing it as the same file.

brandon-groundlight
brandon-groundlight approved these changes Nov 8, 2024
View reviewed changes
Copy link

@brandon-groundlight brandon-groundlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Thanks for cleaning this up

@tyler-romero tyler-romero merged commit fab8574 into main Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-groundlight brandon-groundlight brandon-groundlight approved these changes

@robotrapta robotrapta Awaiting requested review from robotrapta

@tomfaulhaber tomfaulhaber Awaiting requested review from tomfaulhaber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyler-romero @brandon-groundlight