Allow specifying an ID when submitting an image query #271
Conversation
…-sdk into specify-iq-id
CoreyEWood
changed the title
| @@ -54,6 +54,9 @@ test-local: install ## Run tests against a localhost API (needs GROUNDLIGHT_API | |||
| test-integ: install ## Run tests against the integ API server (needs GROUNDLIGHT_API_TOKEN) | |||
| GROUNDLIGHT_ENDPOINT="https://api.integ.groundlight.ai/" ${PYTEST} ${TEST_ARGS} ${CLOUD_FILTERS} test | |||
|
|
|||
| test-dev: install ## Run tests against a dev API server (needs GROUNDLIGHT_API_TOKEN and properly configured dns-hostmap) | |||
There was a problem hiding this comment.
Added this because it seems like it might be useful for the future, but let me know if we don't want this in here.
There was a problem hiding this comment.
I'm indifferent on this one. Only thought I have is that given the above two commands you could instead make these commands set a variable and then call make test using that variable
There was a problem hiding this comment.
Good idea, I made some changes accordingly - let me know if those are what you were envisioning.
There was a problem hiding this comment.
Looks pretty good
Unless we want non-edge users to be specifying ids, I think we should exclude it as a parameter everywhere except for submit_image_query. The other functions are simply convenience wrappers for submit_image_query and having image query id as a parameter is a hit to their ease of use
| @@ -54,6 +54,9 @@ test-local: install ## Run tests against a localhost API (needs GROUNDLIGHT_API | |||
| test-integ: install ## Run tests against the integ API server (needs GROUNDLIGHT_API_TOKEN) | |||
| GROUNDLIGHT_ENDPOINT="https://api.integ.groundlight.ai/" ${PYTEST} ${TEST_ARGS} ${CLOUD_FILTERS} test | |||
|
|
|||
| test-dev: install ## Run tests against a dev API server (needs GROUNDLIGHT_API_TOKEN and properly configured dns-hostmap) | |||
There was a problem hiding this comment.
I'm indifferent on this one. Only thought I have is that given the above two commands you could instead make these commands set a variable and then call make test using that variable
| @@ -995,6 +998,7 @@ components: | |||
| - confidence | |||
| - created_at | |||
| - detector_id | |||
| - source | |||
There was a problem hiding this comment.
Just noting other conversations we've had, this is unrelated to the goal of this PR, but brings this doc back in sync with the BE
…-sdk into specify-iq-id
Adds optional parameter
image_query_idto methods which allow submitting an image query. Adds tests for new parameter. Updates generated code based on new spec.(won't be merged until the backend changes are in production)