Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset detector #242

Merged
merged 18 commits into from
Aug 28, 2024
Merged

Reset detector #242

merged 18 commits into from
Aug 28, 2024

Conversation

brandon-groundlight
Copy link
Collaborator

SDK support for resetting detectors

brandon-groundlight and others added 17 commits August 26, 2024 21:47
@brandon-groundlight
regenerating
115e72d
@brandon-groundlight
add reset detector code
714bcad
Automatically reformatting code
2f937f7
@brandon-groundlight
fix decorator
8580535
Automatically reformatting code
3e32ca1
@brandon-groundlight
sleep time to ensure that the reset job is completed
639db6e
@brandon-groundlight
Merge branch 'reset_detector' of https://github.com/groundlight/pytho…
193eb53 
…n-sdk into reset_detector
Automatically reformatting code
f47ddb8
@brandon-groundlight
longer wait time for background job to run
b3e9d11
@brandon-groundlight
Have even longer wait time to make sure the reset job is complete
f859ccf
Automatically reformatting code
31c42cc
@brandon-groundlight
skipping tests because of potential detector reset delays
003f5ef
@brandon-groundlight
Merge branch 'reset_detector' of https://github.com/groundlight/pytho…
b37ea51 
…n-sdk into reset_detector
Automatically reformatting code
ac4a586
@brandon-groundlight
typo
c865eb1
@brandon-groundlight
Merge branch 'reset_detector' of https://github.com/groundlight/pytho…
bb28c97 
…n-sdk into reset_detector
@brandon-groundlight
appeasing the gods of lint
316ee29
timmarkhuff
timmarkhuff approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@timmarkhuff timmarkhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tyler-romero
tyler-romero approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@tyler-romero tyler-romero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I really wish we didnt have to skip those tests though. How long does the test_reset_retry test take if you poll every second instead of every minute?

@brandon-groundlight
Copy link
Collaborator Author

Thanks for the catch Tyler, what I initially thought was a delay was actually a BE bug that Roxanne just fixed. Turned the tests back on

@brandon-groundlight brandon-groundlight merged commit 25d646a into main Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmarkhuff timmarkhuff timmarkhuff approved these changes

@tyler-romero tyler-romero tyler-romero approved these changes

@roxanne-o roxanne-o Awaiting requested review from roxanne-o

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandon-groundlight @tyler-romero @timmarkhuff