Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast if API token or endpoint is invalid #166

Merged
merged 9 commits into from
Feb 14, 2024
Merged

Conversation

robotrapta
Copy link
Member

@robotrapta robotrapta commented Feb 13, 2024

When a SDK client is instantiated, immediately check connectivity to verify API token and endpoint. Give a helpful error message if something is wrong.

This fixes #38

Copy link
Member

@sunildkumar sunildkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good - I would advocate for adding tests if you have time.

@robotrapta robotrapta merged commit 905dd24 into main Feb 14, 2024
8 checks passed
@robotrapta robotrapta deleted the verify-connectivity branch February 14, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK does not give a helpful error message when GROUNDLIGHT_API_TOKEN is improperly set.
2 participants