-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HLS and YouTube Live support. #60
Conversation
src/framegrab/grabber.py
Outdated
|
||
def _apply_camera_specific_options(self, options: dict) -> None: | ||
if options.get("resolution"): | ||
camera_name = self.config.get("name", "Unnamed {self.type} Stream") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing an f for the f string
I tried out the youtube live streamer and my experience is that it returns the same frame multiple times in a row, making it appear to be very low FPS. Here is what I tried:
This is the output I saw:
|
Fixed the issue! Now hitting 40 FPS with keep_connection_open=True and getting different frames |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add support for HTTP Live Streaming (HLS) and YouTube Live videos (which is just HLS under the hood).
Also do some general cleanup: