Backend improvements and add support for Google Sheet #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeytung
changed the title
brandon-groundlight
approved these changes
Dec 28, 2024
| export WELD_APP_SUPERVISOR_PASSWORD="HASHED_PASSWORD" | ||
| ``` | ||
|
|
||
| For balena deployment just copy the hashed password into the `Device Variables` tab. |
There was a problem hiding this comment.
This is going to be awkward, since we'll need to have them send their desired password, or choose a password for them. Either way involves some password handoff which tends to be an awkward business
| @@ -13,6 +13,8 @@ opencv-python = "4.9.0.80" | |||
| flask = "^3.1.0" | |||
| numpy = "1.26.4" | |||
| rpi-gpio = { version = "^0.7.1", markers = "sys_platform == 'linux' and (platform_machine == 'armv7l' or platform_machine == 'aarch64')" } | |||
| bcrypt = "^4.2.1" | |||
| google-api-python-client = "^2.156.0" | |||
There was a problem hiding this comment.
Could you write a bit more about what we're doing when we connect to google sheets? Is the sheet something the user owns? Do we have any guarantees on its structure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds a couple of new features based on user feedback.
Backend Features:
GoogleAPIServicethat can call Google Sheet to get the part number and its corresponding weld countsFrontend Features:
How to Review
The following files contains most of the changes to support the features mentioned above:
backend.pyandconfig.py: contains all the backend logic and configuration settingsgenerate_hash.py: contains a CLI tool for generating hashed password which is used for generating a new supervisor password.README.md: contains updated instructions, including a new configuration setting that needs to be configured to provide database supportUI testing can be done by cloning the repo and running the application on the local machine with poetry:
The app can be accessed via 127.0.0.1:8000 (Note: GPIO will be disabled due to incompatible architecture)
Additionally, the app can be installed via GL Hub by specifying this repo URL.
Next Steps
UI Previews