fix boxed NSObjects when using as Swift package #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add objc files as separate target see groue#28
|
@herrernst Thanks for your contribution ! Could you tell me how to reproduce the problems that will be fixed by this PR ? E.g. install GRMustach.swift with cocoapods in Obj-C project. |
|
Maybe reference #28 |
|
Sorry for the late reply. Yes, #28 basically explains it. I've made a simple demo project which shows the behavior: https://github.com/herrernst/GRMustacheSwiftTest Basically I want to use an NSObject subclass as context for the renderer. This doesn't not work with current release (4.x.x). If you switch the branch to this pull request
|
fumito-ito
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
@herrernst I got what is the problem that will be fixed by this PR ! Thanks !
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a separate ObjC target with GRMustacheKeyAccess.m and depend on it