release blog: generate release post contents #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub: groongaGH-83 In this PR, we implement a Rake task for generating release announce posts in blog. Generate release announce posts ```console $ rake release:blog:generate $ tree . | grep 2024-11-15-groonga-14.1.0.md │ └── 2024-11-15-groonga-14.1.0.md │ │ └── 2024-11-15-groonga-14.1.0.md ``` ```console $ cat en/_posts/2024-11-15-groonga-14.1.0.md --- layout: post.en title: Groonga 14.1.0 has been released description: Groonga 14.1.0 has been released! --- Groonga 14.1.0 has been released! For installation instructions on your environments, please see the [Installation Guide](/docs/install.html). For the information on the changes, please see the [Release Note](/docs/news/14.html#release-14-1-0-2024-12-04). $ cat ja/_posts/2024-11-15-groonga-14.1.0.md cat ja/_posts/2024-11-05-groonga-14.1.0.md --- layout: post.ja title: Groonga 14.1.0リリース description: Groonga 14.1.0をリリースしました！ --- Groonga 14.1.0をリリースしました！ それぞれの環境毎のインストール方法は、[インストール](/ja/docs/install.html)をご確認ください。 主な変更点のついては、[リリースノート](/ja/docs/news/14.html#release-14-1-0)をご確認ください。 ```
otegami
force-pushed
the
release-post-contents
branch
from
8f49ea3 to
9502f05
Compare
abetomo
reviewed
Dec 4, 2024
release_task.rb
Outdated
|
|
||
| #{@product} #{@version}をリリースしました！ | ||
|
|
||
| それぞれの環境毎のインストール方法は、[インストール](/ja/docs/install.html)をご確認ください。 |
There was a problem hiding this comment.
様々な @product で利用する前提の作りだと思いますが、 /ja/docs/install.html このパスは共通なんでしたっけ？
There was a problem hiding this comment.
GroongaとMroongaは共通なのですが、PGroongaに関しては共通ではないですmm
メソッドに切り出して、overrideしやすいようにしておいたほうが良さそうですね!
kou
changed the title
kou
reviewed
Dec 5, 2024
kou
reviewed
Dec 5, 2024
release_task.rb
Outdated
|
|
||
| それぞれの環境毎のインストール方法は、[インストール](/ja#{product_install_url})をご確認ください。 | ||
|
|
||
| 主な変更点のついては、[リリースノート](/ja#{product_release_note_url})をご確認ください。 |
There was a problem hiding this comment.
Suggested change
| 主な変更点のついては、[リリースノート](/ja#{product_release_note_url})をご確認ください。 | |
| 主な変更点は[リリースノート](/ja#{product_release_note_url})をご確認ください。 |
kou
reviewed
Dec 5, 2024
kou
reviewed
Dec 5, 2024
release_task.rb
Outdated
Comment on lines
112
to
119
| case locale | ||
| when "ja" | ||
| post_ja_content | ||
| when "en" | ||
| post_en_content | ||
| else | ||
| raise "#{locale} isn't supported for release announce posts in blog." | ||
| end |
There was a problem hiding this comment.
Suggested change
| case locale | |
| when "ja" | |
| post_ja_content | |
| when "en" | |
| post_en_content | |
| else | |
| raise "#{locale} isn't supported for release announce posts in blog." | |
| end | |
| __send__("post_#{locale}_content") |
post_content_#{locale}にしてpost_contentをprefixにして関連処理であることをアピールしたほうがいいかも。
There was a problem hiding this comment.
fix: ed63a9e
ありがとうございます。わざわざ例外を挙げなくても、NoMethodErrorで気づけますし何をしているか、たしかにわかりやすいですね 🙏🏾
post_content_#{locale}にしてpost_contentをprefixにして関連処理であることをアピールしたほうがいいかも。
確かにです！
|
ここまで頂いたレビューコメントの対応を行いました！ |
|
descriptionを最新情報に更新してもらえますか？ |
otegami
changed the title
|
すみません。更新しましたmm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: GH-83
In this PR, we implement a Rake task for generating release announce posts with contents in blog.
Generate release announce posts