cmake: fix destination path #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because CMAKE_LIBDIR is none currently. Thus, groonga-normalizer-mysql.pc is installed to groonga-normalizer-mysql-1.2.3/groonga-normalizer-mysql.pc
komainu8
changed the title
kou
reviewed
Nov 2, 2023
CMakeLists.txt
Outdated
| "share/${GROONGA_NORMALIZER_MYSQL_PROJECT_NAME}") | ||
| if(NOT DEFINED GROONGA_NORMALIZER_MYSQL_DOC_DIR) | ||
| set(GROONGA_NORMALIZER_MYSQL_DOC_DIR | ||
| "share/doc/${GROONGA_NORMALIZER_MYSQL_PROJECT_NAME}") |
There was a problem hiding this comment.
We should use CMAKE_INSTALL_DOCDIR by including GNUInstallDirs:
| @@ -46,6 +46,7 @@ This package provides development files for groonga-normalizer-mysql. | |||
| %cmake \ | |||
| -DCMAKE_BUILD_TYPE=Release \ | |||
| -DCMAKE_INSTALL_SYSCONFDIR:PATH=%{_sysconfdir} \ | |||
| -DCMAKE_LIBDIR=%{_libdir} \ | |||
There was a problem hiding this comment.
We should use CMAKE_INSTALL_LIBDIR by including GNUInstallDirs instead of specifying CMAKE_LIBDIR explicitly.
|
Thank you for your comments. I've fixed them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
share/${GROONGA_NORMALIZER_MYSQL_PROJECT_NAME}is shownshare/groonga-normalizer-mysql.Thus,
README.mdanddoc/text/lgpl-2.0.txtare installed inshare/groonga-normalizer-mysql/.However, these files are installed
share/doc/groonga-normalizer-mysql/for RPM packages.See: https://github.com/groonga/groonga-normalizer-mysql/blob/main/packages/yum/groonga-normalizer-mysql.spec.in#L59C1-L59C42
I change destination path
share/groonga-normalizer-mysqltoshare/doc/groonga-normalizer-mysql.https://github.com/groonga/groonga-normalizer-mysql/blob/main/CMakeLists.txt#L97 is defined
DESTINATION "${CMAKE_LIBDIR}/pkgconfig/".However,
CMAKE_LIBDIRis not definition. (Probably,CMAKE_LIBDIRis null.)Thus,
groonga-normalizer-mysql.pcis installed topkgconfig/. This install path is not expected.I change destination path
pkgconfig/tousr/lib64(or lib)/pkgconfig.