Async impl example #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses future to hold both the async result and exception, allowing us to get rid of expected - moves the bounds checking to the mapping where it's more appropriate (it's a pedantic thing for a 1D mdspan, but it makes the example more idiomatic)
|
(Okay, now I merged in your changes. I can also go to your 2x3 version also if you want) |
Note to self: don't merge directly on GitHub
|
Okay generalized to multidimensional to match where your example is now. This is so cool! Thanks for involving me! |
|
I brought a 6 pack of beer for the robot to check and am going to attempt a love demo, so, you're call. |
|
This looks really clean. It's really cool to see the layout bounds checking code, and it never occurred to me that the reference type can be a value type. I really like using expected and will probably refactor that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Sorry this took so long; also sorry I haven't incorporated changes you made since I started playing with this)