Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add-parameters #6

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Feature/add-parameters #6

merged 2 commits into from
Nov 21, 2024

Conversation

shhlife
Copy link
Contributor

@shhlife shhlife commented Nov 20, 2024

added validators for relevant parameters, and added additional parameters to match the api specs.

Fixes #5

@shhlife shhlife requested a review from collindutter November 20, 2024 23:39
Copy link
Member

@collindutter collindutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@shhlife shhlife merged commit 6ef2067 into main Nov 21, 2024
9 checks passed
@shhlife shhlife deleted the feature/add-parameters branch November 21, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A few parameters need to be moved/added
2 participants