Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added parameters #4

Merged
merged 5 commits into from
Nov 20, 2024
Merged

added parameters #4

merged 5 commits into from
Nov 20, 2024

Conversation

shhlife
Copy link
Contributor

@shhlife shhlife commented Nov 20, 2024 •
edited
Loading

Added docstring and additional parameters as per api specs.

Closes #2

@shhlife shhlife requested a review from collindutter November 20, 2024 18:06
@shhlife shhlife linked an issue Nov 20, 2024 that may be closed by this pull request
add additional parameters for the various models #2
Closed
@collindutter
Copy link
Member

Does this close #2? If so, should update PR description with "Closes #2"

@shhlife shhlife merged commit 312cdd8 into main Nov 20, 2024
9 checks passed
@shhlife shhlife deleted the feature/new-parameters branch November 20, 2024 18:30
@shhlife shhlife linked an issue Nov 20, 2024 that may be closed by this pull request
A few parameters need to be moved/added #5
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collindutter collindutter collindutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A few parameters need to be moved/added add additional parameters for the various models
2 participants
@shhlife @collindutter