Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with autoconf 2.72 #232

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

ellert
Copy link
Member

@ellert ellert commented Oct 30, 2024

@fscheiner
Copy link
Member

Looks good to me. Thanks for fixing, @ellert.

I only wonder what changed outside of the GCT that the old code now made a problem.

@ellert ellert force-pushed the protect-against-empty-ac-var branch from baca93a to 53a4778 Compare October 30, 2024 15:37
@ellert
Copy link
Member Author

ellert commented Oct 30, 2024

I only wonder what changed outside of the GCT that the old code now made a problem.

I had a closer look, and this is due to changes in autoconf 2.72.
I have therefore reworked the pull request. Please review again.

@ellert ellert changed the title Protect against empty ac_cv_sys_file_offset_bits Compatibility with autoconf 2.72 Oct 30, 2024
Copy link
Member

@fscheiner fscheiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that (i.e. [...]file_offset_bits) is no longer relevant for autoconf 2.72, I'd say let's do this.

if test X"$ac_cv_sys_largefile_CC" != "Xno"; then
LARGEFILE_CFLAGS="$ac_cv_sys_largefile_CC"
AC_SUBST(LARGEFILE_CFLAGS)
fi
if test X"$ac_cv_sys_file_offset_bits" != "Xno" && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this (i.e. [...]file_offset_bits) is no longer relevant for autoconf 2.72, I guess?

@fscheiner
Copy link
Member

Also the failing check should be fixed by #233.

@ellert ellert merged commit b10f3a9 into gridcf:master Oct 31, 2024
6 of 7 checks passed
@ellert ellert deleted the protect-against-empty-ac-var branch October 31, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants