64 bit time_t #223
Merged
64 bit time_t #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fscheiner
force-pushed
the
format-issues
branch
from
a07ad6f to
9d77f47
Compare
|
This took a few iterations to find all corner cases, but I think it is complete now. At least there are no more compiler warnings related to the change, and the tests succeed on all debian architectures for all packages. |
msalle
requested changes
Apr 10, 2024
msalle
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian recently migrated to using a 64 bit time_t on most of their 32 bit architectures.
This leads to issues where a time_t variable is used in printf or sscanf.
This PR addresses those issues (and a few cases with size_t vs. long that I found when checking logs on 32 bit).