Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder local numbering for quad and hex #25

Merged

Conversation

jesusbonilla
Copy link

Quick fix for issue #3

Jesus Bonilla added 2 commits September 18, 2020 13:09
* Added a reordering of local node numbering when importing quads and hexs
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #25 into master will increase coverage by 1.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   93.64%   94.78%   +1.13%     
==========================================
  Files           2        2              
  Lines         346      364      +18     
==========================================
+ Hits          324      345      +21     
+ Misses         22       19       -3     
Impacted Files Coverage Δ
src/GmshDiscreteModels.jl 94.94% <100.00%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4245e1c...e249ec0. Read the comment docs.

@AndiMD
Copy link

AndiMD commented Sep 21, 2020

@jesusbonilla: Thanks for trying to solve this. I noticed however, that the .vtu export looks incorrect in Paraview:
image

@jesusbonilla
Copy link
Author

Ok, I will take a look and see what is going on.

@AndiMD
Copy link

AndiMD commented Sep 22, 2020

I was able to fix this by adding all ungrouped hex volumes into a group ("Solid_2"). I still have to save the .med file as .msh first, though.
Mesh_SimpleHex_AllGroups.med.zip

@fverdugo
Copy link
Member

@jesusbonilla, after de discussion in #3 #25 do you think it is save for merge this? it is ready or you want to do more changes?

@jesusbonilla
Copy link
Author

@fverdugo I think it is safe to merge this. However, I would not close #3 until we know what is wrong with some med meshes.

@fverdugo fverdugo merged commit cc43be0 into gridap:master Sep 25, 2020
@jesusbonilla jesusbonilla deleted the reorder_local_numbering_for_quad_and_hex branch September 30, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants