Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to reorder nodes, elements #24

Merged
merged 2 commits into from
Sep 19, 2020
Merged

Option to reorder nodes, elements #24

merged 2 commits into from
Sep 19, 2020

Conversation

AndiMD
Copy link

@AndiMD AndiMD commented Sep 18, 2020

Gmsh does not enforce consecutive numbering, but GmshDiscreteModel requires that. Gmsh has 2 builtin functions that seem to make it work.

AndiMD added 2 commits September 18, 2020 19:55
- UnstructuredDiscreteModel errors nodes and elements are not numbered consecutively.
Test mesh TwoTetraeder.msh
@fverdugo fverdugo merged commit 4245e1c into gridap:master Sep 19, 2020
@fverdugo
Copy link
Member

Thanks @AndiMD !

Do you think this is somehow related to #3 ?

Cc @jesusbonilla

@AndiMD
Copy link
Author

AndiMD commented Sep 19, 2020

@fverdugo: Thanks for merging this. It allows loading .MED meshes created with Salome Platform (IMO the best OpenSource Geometry/Meshing software), since gmsh seamlessly converts it.
Unfortunately this does not improve the situation with #3. I will see if I can resolve this next, no promises though.

@jesusbonilla
Copy link

I have resolved issue of #3 in my fork. As @fverdugo suggested it is related with the local numbering used in Gridap vs Gmsh. Commit 6e70a00 implements a quick fix for it. We can merge it as is, or I can make any improvements required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants