Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support for ghosted/unghosted distributed triangulations #100

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

JordiManyer
Copy link
Member

@JordiManyer JordiManyer commented Nov 14, 2024

In GridapDistributed, we generally allow the creation of ghosted/unghosted versions of objects. Although generally we require unghosted triangulations for integration, having both is usually required for more complex stuff.

The original version of the distributed code does not allow this. In fact, the code avoids doing cuts on ghosted cells. This was probably done to avoid repeating work, but it limits the potential of the distributed code. One example where the current implementation is not flexible enough is taking Skeleton/Boundary triangulations of a distributed SubFacetTriangulation, where we require access to the cuts on ghost cells in order to properly distinguish between interior and boundary faces.

In terms of performance, I would argue that creating model views to create the cuts and then mapping the cuts back to the original model is a lot more costly than doing the cuts on the ghost cells then masking out the result.
This also results is quite a lot less code, and better one-to-one comparison with what we do in GridapDistributed.

All in all, I propose changes to address all the above.

@JordiManyer JordiManyer marked this pull request as ready for review November 14, 2024 10:48
@zjwegert
Copy link
Contributor

I've added this in #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants